Retry connection with the backend of access logs #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keksoj
force-pushed
the
log-target-error
branch
from
c2951bb
to
79ded6d
Compare
FlorentinDUBOIS
requested changes
Apr 22, 2024
Keksoj
force-pushed
the
log-target-error
branch
from
dde8b7f
to
edb9b94
Compare
FlorentinDUBOIS
requested changes
Apr 24, 2024
Keksoj
force-pushed
the
log-target-error
branch
4 times, most recently
from
3c734ba
to
90ab435
Compare
llenotre
reviewed
Jul 8, 2024
startup fails when access logs backend is not responding create const DEFAULT_LOG_TARGET with value "stdout" Co-Authored-By: Eloi DEMOLIS <eloi.demolis@clever-cloud.com>
Signed-off-by: Eloi DEMOLIS <eloi.demolis@clever-cloud.com>
FlorentinDUBOIS
previously requested changes
Jul 15, 2024
Keksoj
dismissed
FlorentinDUBOIS’s stale review
the PR was reviewed with @llenotre who approved of my points
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, a failure in transmitting access logs (e.g. a UNIX socket not responding/existing) would mean that Sōzu would not emit access logs anymore.
This pull request:
revive_backendfunctionaccess_logs_targetis given inconfig.toml, it will still default to stdout)Additionally, this PR adds error types and propagation.